[
https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967200#comment-15967200
]
ASF GitHub Bot commented on FLINK-6090:
---------------------------------------
Github user hequn8128 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3696#discussion_r111320841
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCorrelate.scala
---
@@ -36,14 +36,14 @@ import org.apache.flink.types.Row
class DataStreamCorrelate(
cluster: RelOptCluster,
traitSet: RelTraitSet,
- inputNode: RelNode,
--- End diff --
hi, sorry for missing any commons about this fix. After decoration phase,
the class type of inputNode is `HepRelVertex` and it will throws
ClassCastException at `val inputDS =
inputNode.asInstanceOf[DataStreamRel].translateToPlan(tableEnv)`. You can
reproduce this exception by running tests in
`DataStreamUserDefinedFunctionITCase`. The reason why there is no problems
after runVolcanoPlanner is that `DataStreamCorrelateRule` does the
transformation from `RelSubset` to `DataStreamRel`. I think it's better to
override the `input` parameter and use `getInput` when translate to plan. What
do you think, thx~
> Add RetractionRule at the stage of decoration
> ---------------------------------------------
>
> Key: FLINK-6090
> URL: https://issues.apache.org/jira/browse/FLINK-6090
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Hequn Cheng
>
> Implement optimizer for retraction:
> 1.Add RetractionRule at the stage of decoration，which can derive the
> replace table/append table, NeedRetraction property.
> 2.Match the NeedRetraction and replace table, mark the accumulating mode
>
> When this task is finished, we can turn on retraction for different operators
> according to accumulating mode.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
