[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-6130:
--------------------------
Description:
In YarnFlinkApplicationMasterRunner#runApplicationMaster() :
{code}
synchronized (lock) {
LOG.info("Starting High Availability Services");
...
}
// wait for resource manager to finish
resourceManager.getTerminationFuture().get();
{code}
resourceManager#getTerminationFuture() is called without holding lock.
We should store the value returned from resourceManager#getTerminationFuture()
inside the synchronized block.
was:
In YarnFlinkApplicationMasterRunner#runApplicationMaster() :
{code}
synchronized (lock) {
LOG.info("Starting High Availability Services");
...
}
// wait for resource manager to finish
resourceManager.getTerminationFuture().get();
{code}
resourceManager#getTerminationFuture() is called without holding lock.
We should store the value returned from resourceManager#getTerminationFuture()
inside the synchronized block.
> Consider calling resourceManager#getTerminationFuture() with lock held
> ----------------------------------------------------------------------
>
> Key: FLINK-6130
> URL: https://issues.apache.org/jira/browse/FLINK-6130
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> In YarnFlinkApplicationMasterRunner#runApplicationMaster() :
> {code}
> synchronized (lock) {
> LOG.info("Starting High Availability Services");
> ...
> }
> // wait for resource manager to finish
> resourceManager.getTerminationFuture().get();
> {code}
> resourceManager#getTerminationFuture() is called without holding lock.
> We should store the value returned from
> resourceManager#getTerminationFuture() inside the synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
