[ https://issues.apache.org/jira/browse/FLINK-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958495#comment-15958495 ]
ASF GitHub Bot commented on FLINK-6261: --------------------------------------- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3675 Thanks for the review @haohui! You're right about the code duplication. I had started with addressing DataSet and DataStream in one class but ended up with many `if(stream)` conditions. I'll refactor that into an abstract class with two subclasses and update the PR soon. > Add support for TUMBLE, HOP, SESSION to batch SQL > ------------------------------------------------- > > Key: FLINK-6261 > URL: https://issues.apache.org/jira/browse/FLINK-6261 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Affects Versions: 1.3.0 > Reporter: Fabian Hueske > Assignee: Fabian Hueske > > Add support for the TUMBLE, HOP, SESSION keywords for batch SQL. -- This message was sent by Atlassian JIRA (v6.3.15#6346)