[ 
https://issues.apache.org/jira/browse/FLINK-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953486#comment-15953486
 ] 

ASF GitHub Bot commented on FLINK-5994:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3656#discussion_r109416659
  
    --- Diff: flink-libraries/flink-table/pom.xml ---
    @@ -231,6 +231,25 @@ under the License.
                                </configuration>
                        </plugin>
     
    +                   <!-- build a har-with-dependencies, to be included in 
the 'opt' build folder -->
    +                   <plugin>
    +                           <artifactId>maven-assembly-plugin</artifactId>
    +                           <configuration>
    +                                   <descriptorRefs>
    +                                           
<descriptorRef>jar-with-dependencies</descriptorRef>
    --- End diff --
    
    The jar-with-dependencies is 86MB. This would increase the distribution 
from 120 MB to 200 MB. 
    I looked into the jar file and it contains all dependencies of 
`flink-table`, including the other Flink dependencies and their transitive 
dependencies (netty, hadoop, avro, etc.). We need to exclude all of that and 
only keep those dependencies that we really need. 


> Add Janino to flink-table JAR file
> ----------------------------------
>
>                 Key: FLINK-5994
>                 URL: https://issues.apache.org/jira/browse/FLINK-5994
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Timo Walther
>            Assignee: sunjincheng
>
> It seems that Janino is not part of the flink-table JAR file although it is a 
> dependency in pom.xml. Users adding flink-table to Flink's lib folder because 
> of FLINK-5227 cannot run table program due to the missing Janino dependency.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to