Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3647#discussion_r109032005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -857,28 +857,30 @@ object AggregateUtil {
aggregateCalls: Seq[AggregateCall],
inputType: RelDataType,
needRetraction: Boolean)
- : (Array[Int], Array[TableAggregateFunction[_ <: Any]]) = {
+ : (Array[util.List[Integer]], Array[TableAggregateFunction[_ <: Any]]) =
{
--- End diff --
Can we use an `Array[Int]` instead of a `List[Integer]`?
Scala `Int` is compiled to Java `int` primitive. `java.lang.Integer` is a
boxed type.
Also an array access is faster than a `List.get()` access
(`ArrayList.get()` would be a bit better).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
