Github user shixiaogang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3652#discussion_r108868469
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/ListViaMergeSpeedMiniBenchmark.java
---
@@ -50,55 +50,59 @@ public static void main(String[] args) throws Exception
{
final RocksDB rocksDB = RocksDB.open(options,
rocksDir.getAbsolutePath());
- final String key = "key";
- final String value =
"abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ7890654321";
+ try {
--- End diff --
I think it's better to use try-with-resources here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
