[ 
https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946914#comment-15946914
 ] 

ASF GitHub Bot commented on FLINK-5653:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3574#discussion_r108644799
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
 ---
    @@ -350,4 +350,59 @@ class WindowAggregateTest extends TableTestBase {
         streamUtil.verifySql(sql, expected)
       }
     
    +  @Test
    +  def testBoundedNonPartitionedProcessingWindowWithRow() = {
    +    val sql = "SELECT " +
    +      "c, " +
    +      "count(a) OVER (ORDER BY procTime() ROWS BETWEEN 2 preceding AND " +
    +      "CURRENT ROW) as cnt1 " +
    +      "from MyTable"
    +
    +    val expected =
    +      unaryNode(
    +        "DataStreamCalc",
    +        unaryNode(
    +          "DataStreamOverAggregate",
    +          unaryNode(
    +            "DataStreamCalc",
    +            streamTableNode(0),
    +            term("select", "a", "c", "PROCTIME() AS $2")
    +          ),
    +          term("orderBy", "PROCTIME"),
    +          term("rows", "BETWEEN 2 PRECEDING AND CURRENT ROW"),
    +          term("select", "a", "c", "PROCTIME", "COUNT(a) AS w0$o0")
    +        ),
    +        term("select", "c", "w0$o0 AS $1")
    +      )
    +    streamUtil.verifySql(sql, expected)
    +  }
    +  
    +  @Test
    +  def testBoundedPartitionedProcessingWindowWithRow() = {
    +    val sql = "SELECT " +
    +      "c, " +
    +      "count(a) OVER (PARTITION BY c ORDER BY procTime() ROWS BETWEEN 2 
preceding AND " +
    --- End diff --
    
    It's Okay.


> Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL
> --------------------------------------------------------------------
>
>                 Key: FLINK-5653
>                 URL: https://issues.apache.org/jira/browse/FLINK-5653
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Stefano Bortoli
>
> The goal of this issue is to add support for OVER ROWS aggregations on 
> processing time streams to the SQL interface.
> Queries similar to the following should be supported:
> {code}
> SELECT 
>   a, 
>   SUM(b) OVER (PARTITION BY c ORDER BY procTime() ROWS BETWEEN 2 PRECEDING 
> AND CURRENT ROW) AS sumB,
>   MIN(b) OVER (PARTITION BY c ORDER BY procTime() ROWS BETWEEN 2 PRECEDING 
> AND CURRENT ROW) AS minB
> FROM myStream
> {code}
> The following restrictions should initially apply:
> - All OVER clauses in the same SELECT clause must be exactly the same.
> - The PARTITION BY clause is optional (no partitioning results in single 
> threaded execution).
> - The ORDER BY clause may only have procTime() as parameter. procTime() is a 
> parameterless scalar function that just indicates processing time mode.
> - UNBOUNDED PRECEDING is not supported (see FLINK-5656)
> - FOLLOWING is not supported.
> The restrictions will be resolved in follow up issues. If we find that some 
> of the restrictions are trivial to address, we can add the functionality in 
> this issue as well.
> This issue includes:
> - Design of the DataStream operator to compute OVER ROW aggregates
> - Translation from Calcite's RelNode representation (LogicalProject with 
> RexOver expression).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to