[
https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944908#comment-15944908
]
ASF GitHub Bot commented on FLINK-6204:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3630
[FLINK-6204][table]Improve Event-Time OVER ROWS BETWEEN UNBOUNDED PRE…
…CEDING aggregation to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [×] General
- The pull request references the related JIRA issue ("[FLINK-6204]
Improve Event-Time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [×] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6204-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3630
----
commit c1ec940d77e67192cc8fd82f65b2d176104be7f2
Author: 金竹 <jincheng.su...@alibaba-inc.com>
Date: 2017-03-28T10:05:00Z
[FLINK-6204][table]Improve Event-Time OVER ROWS BETWEEN UNBOUNDED PRECEDING
aggregation to SQL
----
> Improve Event-Time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL
> ---------------------------------------------------------------------------
>
> Key: FLINK-6204
> URL: https://issues.apache.org/jira/browse/FLINK-6204
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Currently `event time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to
> SQL` implementation class: ` UnboundedEventTimeOverProcessFunction` use
> data size uncontrollable memory data structures`sortedTimestamps:
> util.LinkedList [Long] cache data timestamps and sort timestamps. IMO,It's
> not a good way, because in the production environment there are millions of
> window data pre millisecond in our application scenario.So, I want to remove
> `util.LinkedList [Long] `. Welcome anyone to give me feedback.
> What do you think? [~fhueske] and [~Yuhong_kyo]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
