GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3610

    [FLINK-6183]/[FLINK-6184] Prevent some NPE and unclosed metric groups

    This PR fixes 2 issues:
    
    1) It prevents some NPEs in the buffer metrics by instantiating them after 
the task has been registered in the NetworkEnvironment.
    
    2) It prevents some cases where the TaskMetricGroup would never be closed. 
These cases include an early exit in `Task#run()` and when 2) tasks with an 
identical ExecutionAttemptID are run on the same TM.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6183_6184_metric_task

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3610
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to