Github user docete commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3579#discussion_r107081399
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -916,6 +916,10 @@ object AggregateUtil {
                       new DecimalMinAggFunction
                     case BOOLEAN =>
                       new BooleanMinAggFunction
    +                case VARCHAR =>
    +                  new StringMinAggFunction
    +                case CHAR =>
    --- End diff --
    
    for 1 and 2, i will add max/minWithRetractAggFunction, ut, and integration 
test.
    for 3, we do support CHAR type in SQL, not in table api.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to