Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3562#discussion_r106775966
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
 ---
    @@ -162,22 +176,422 @@ protected CheckpointStreamFactory 
createStreamFactory() throws Exception {
        }
     
        @Test
    +   public void testBackendUsesRegisteredKryoDefaultSerializer() throws 
Exception {
    +           CheckpointStreamFactory streamFactory = createStreamFactory();
    +           Environment env = new DummyEnvironment("test", 1, 0);
    +           AbstractKeyedStateBackend<Integer> backend = 
createKeyedBackend(IntSerializer.INSTANCE, env);
    +
    +           // cast because our test serializer is not typed to TestPojo
    +           env.getExecutionConfig()
    +                           .addDefaultKryoSerializer(TestPojo.class, 
(Class) ExceptionThrowingTestSerializer.class);
    +
    +           TypeInformation<TestPojo> pojoType = new 
GenericTypeInfo<>(TestPojo.class);
    +
    +           // make sure that we are in fact using the KryoSerializer
    +           assertTrue(pojoType.createSerializer(env.getExecutionConfig()) 
instanceof KryoSerializer);
    +
    +           pojoType.createSerializer(env.getExecutionConfig());
    --- End diff --
    
    I think this is redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to