[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930204#comment-15930204
]
ASF GitHub Bot commented on FLINK-4460:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106684096
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -567,6 +600,17 @@ protected boolean isLate(W window) {
}
/**
+ * Decide if a record is currently late, based on current watermark and
allowed lateness.
+ *
+ * @param element The element to check
+ * @return The element for which should be considered when sideoutputs
+ */
+ protected boolean isLate(StreamRecord<IN> element){
--- End diff --
I must have removed the check by accident. I think we agreed to rename this
to something more meaningful and keep it, right?
> Side Outputs in Flink
> ---------------------
>
> Key: FLINK-4460
> URL: https://issues.apache.org/jira/browse/FLINK-4460
> Project: Flink
> Issue Type: New Feature
> Components: Core, DataStream API
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chen Qin
> Assignee: Chen Qin
> Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
