Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r106684096
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
 ---
    @@ -567,6 +600,17 @@ protected boolean isLate(W window) {
        }
     
        /**
    +    * Decide if a record is currently late, based on current watermark and 
allowed lateness.
    +    *
    +    * @param element The element to check
    +    * @return The element for which should be considered when sideoutputs
    +    */
    +   protected boolean isLate(StreamRecord<IN> element){
    --- End diff --
    
    I must have removed the check by accident. I think we agreed to rename this 
to something more meaningful and keep it, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to