Github user EronWright commented on the pull request:
https://github.com/apache/flink/commit/e2f01b81e801a5ae6610d06fb9e2e3f54bbf34d9#commitcomment-21361837
In
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java:
In
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
on line 244:
You took the wrong shortcut here to access the Flink configuration. This
code erroneously says, "get the configured framework name *from the JM's
dynamic configuration only*". This code would fail if the
`mesos.rm.framework.name` property were instead set in the JM's static
configuration.
It is undesirable to use the raw configuration at this stage anyway. You
probably notice that Flink 'eagerly' processes its configuration into typed
objects like `MesosConfiguration` Let's use that here too. Please change
`LaunchableMesosWorker` constructor to take `MesosConfiguration` as a
parameter. Use `mesosConfig.frameworkInfo().getName()` when setting
`ENV_FRAMEWORK_NAME`. Change
`MesosFlinkResourceManager::createLaunchableMesosWorker` to pass the
`mesosConfig` that it has.
Please adjust the handling of `TASK_MANAGER_HOSTNAME_KEY` in the same way.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
