Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106538072
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,9 +113,14 @@ class DataStreamOverAggregate(
if (overWindow.lowerBound.isUnbounded &&
overWindow.upperBound.isCurrentRow) {
createUnboundedAndCurrentRowProcessingTimeOverWindow(inputDS)
+ } // lowerbound is a BasicType and upperbound is PRECEEDING or
CURRENT ROW
+ else if
(overWindow.lowerBound.getOffset.getType.isInstanceOf[BasicSqlType]
--- End diff --
What is the check
`overWindow.lowerBound.getOffset.getType.isInstanceOf[BasicSqlType]` for and
why do you check if `overWindow.upperBound.isPreceding`?
Should the condition rather be like this:
```
else if (overWindow.lowerBound.isPreceding() &&
!overWindow.lowerBound.isUnbounded() && // bounded preceding
overWindow.upperBound.isCurrentRow() && // until current row
overWindow.isRows) // is rows window
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
