Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106362409
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class DataSetCalc(
traitSet: RelTraitSet,
input: RelNode,
rowRelDataType: RelDataType,
- private[flink] val calcProgram: RexProgram, // for tests
+ calcProgram: RexProgram,
ruleDescription: String)
- extends SingleRel(cluster, traitSet, input)
+ extends Calc(cluster, traitSet, input, calcProgram)
--- End diff --
OK, sounds good to me. I was just curious, because I remembered we had some
issues when `DataSetCalc` extended `Calc`. If everything works fine, I'm OK
with this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
