[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926514#comment-15926514 ]
Bowen Li commented on FLINK-6053: --------------------------------- I see. I can do a hack in FLINK-6013 to check if a Gauge is typed as Number before sending it as a datadog metric. Do you still feel it's necessary to make this change? If not, I can close this issue. > Gauge<T> should only take subclasses of Number, rather than everything > ---------------------------------------------------------------------- > > Key: FLINK-6053 > URL: https://issues.apache.org/jira/browse/FLINK-6053 > Project: Flink > Issue Type: Improvement > Components: Metrics > Affects Versions: 1.2.0 > Reporter: Bowen Li > Fix For: 2.0.0 > > > Currently, Flink's Gauge is defined as > ```java > public interface Gauge<T> extends Metric { > T getValue(); > } > ``` > But it doesn't make sense to have Gauge take generic types other than Number. > And it blocks I from finishing FLINK-6013, because I cannot assume Gauge is > only about Number. So the class should be like > ```java > public interface Gauge<T extends Number> extends Metric { > T getValue(); > } > ``` -- This message was sent by Atlassian JIRA (v6.3.15#6346)