[
https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926156#comment-15926156
]
ASF GitHub Bot commented on FLINK-3849:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106134112
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.sources
+
+import org.apache.flink.table.expressions.Expression
+
+/**
+ * Adds support for filtering push-down to a [[TableSource]].
+ * A [[TableSource]] extending this interface is able to filter records
before returning.
+ */
+trait FilterableTableSource[T] extends TableSource[T] {
+
+ /**
+ * Indicates whether the filter push down has been applied. Note that
even if we don't
+ * actually push down any filters, we should also set this flag to true
after the trying.
+ */
+ private var filterPushedDown: Boolean = false
+
+ /**
+ * Check and pick all predicates this table source can support. The
passed in predicates
+ * have been translated in conjunctive form, and table source can only
pick those predicates
+ * that it supports.
+ * <p>
+ * After trying to push predicates down, we should return a new
[[FilterableTableSource]]
+ * instance which holds all pushed down predicates. Even if we actually
pushed nothing down,
+ * it is recommended that we still return a new
[[FilterableTableSource]] instance since we will
+ * mark the returned instance as filter push down has been tried. Also
we need to return all
+ * unsupported predicates back to the framework to do further filtering.
+ * <p>
+ * We also should note to not changing the form of the predicates
passed in. It has been
+ * organized in CNF conjunctive form, and we should only take or leave
each element in the
+ * array. Don't try to reorganize the predicates if you are absolutely
confident with that.
+ *
+ * @param predicate An array contains conjunctive predicates.
+ * @return A new cloned instance of [[FilterableTableSource]] as well
as n array of Expression
+ * which contains all unsupported predicates.
+ */
+ def applyPredicate(predicate: Array[Expression]):
(FilterableTableSource[_], Array[Expression])
+
+ /**
+ * Return the flag to indicate whether filter push down has been tried.
+ */
+ def isFilterPushedDown: Boolean = filterPushedDown
--- End diff --
I'm not sure about the `isFilterPushedDown` and `setFilterPushDown`
methods. They seem to unnecessarily blow up the interface (at least for Java
classes that implement the trait).
Can't we track in `TableSourceScan` if we tried to push a filter down?
> Add FilterableTableSource interface and translation rule
> --------------------------------------------------------
>
> Key: FLINK-3849
> URL: https://issues.apache.org/jira/browse/FLINK-3849
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Kurt Young
>
> Add a {{FilterableTableSource}} interface for {{TableSource}} implementations
> which support filter push-down.
> The interface could look as follows
> {code}
> def trait FilterableTableSource {
> // returns unsupported predicate expression
> def setPredicate(predicate: Expression): Expression
> }
> {code}
> In addition we need Calcite rules to push a predicate (or parts of it) into a
> TableScan that refers to a {{FilterableTableSource}}. We might need to tweak
> the cost model as well to push the optimizer in the right direction.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
