[
https://issues.apache.org/jira/browse/FLINK-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924518#comment-15924518
]
ASF GitHub Bot commented on FLINK-6050:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3537
[FLINK-6050] [robustness] Register exception handler on thenAccept futures
When applying an AcceptFunction on a Future x, then we should register the
exception handler
on the returned thenAccept future instead of on x. This has the advantage
that we also catch
exceptions which are thrown inside of the AcceptFunction and not only those
which originate
from x. The PR adapts the code respectively.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink hardenAcceptFutureCalls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3537
----
----
> Improve failure reporting when using Future.thenAccept
> ------------------------------------------------------
>
> Key: FLINK-6050
> URL: https://issues.apache.org/jira/browse/FLINK-6050
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> When applying {{Future.thenAccept(Async)}} onto a {{Future}}, then we should
> register the exception handler on the returned {{Future<Void>}} and not on
> the original future. This has the advantage that we also catch exceptions
> which are thrown in the {{AcceptFunction}} and not only those originating
> from the original {{Future}}. This improve Flink's behaviour, because
> exceptions are not swallowed in the returned {{Future}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
