Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3514#discussion_r105648422
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java
 ---
    @@ -58,7 +59,17 @@
         * An array of sets of keys keeping the registered keys split
         * by the key-group they belong to. Each key-group has one set.
         */
    -   private final Set<K>[] keysByKeygroup;
    +   private final Set<K>[] registeredKeysByKeyGroup;
    +
    +   /**
    +    * An array of sets of keys keeping the keys "to delete" split
    +    * by the key-group they belong to. Each key-group has one set.
    +    * <p>
    --- End diff --
    
    IMHO, the formatting on paragraphs should be:
    ```
    Some text bla bla black
    
    <p>Other Text sdfasfaf
    ```
    
    on the other hand, we don't have a style guide on that and no checkstyle 
for checking it .... 😉 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to