GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/3517

    [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo serialization

    (This PR should also be backported for `release-1.1` and `release-1.2`. 
Separate PRs are not opened for the backports because it is a relatively 
self-contained change.)
    
    This PR adds a reimplemented `JavaSerializer` to be registered with
    Kryo. This is due to a know issue with Kryo's `JavaSerializer` that may
    use the wrong classloader for deserialzation (see 
https://github.com/EsotericSoftware/kryo/pull/483).
    
    Since we by default register Kryo's `JavaSerializer` for `Throwable`s, 
users who need to serialize exception types as messages bump into 
`ClassNotFoundException`s.
    Instead of registering Kryo's `JavaSerializer` for `Throwables`, it is now 
changed to register the reimplemented `JavaSerializer`.
    
    Generally, users who bump into `ClassNotFoundException`s if they are using 
Kryo's `JavaSerializer` for
    their own custom types are also recommended to change to Flink's 
`JavaSerializer`.
    
    The change is tested using the minimal issue reproducing example provided 
by our users in 
http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/AWS-exception-serialization-problem-td12063.html.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-6025

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3517
    
----
commit 0e85ec1bf0a11c67e2af3625e0858e22b41600cd
Author: Tzu-Li (Gordon) Tai <tzuli...@apache.org>
Date:   2017-03-12T14:46:27Z

    [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo serialization
    
    This commit adds a reimplemented JavaSerializer to be registered with
    Kryo. This is due to a know issue with Kryo's JavaSerializer that may
    use the wrong classloader for deserialzation.
    
    Instead of registering Kryo's JavaSerializer for Throwables, it is now
    changed to register the reimplemented JavaSerializer. Users who bump
    into ClassNotFoundExceptions if they are using Kryo's JavaSerializer for
    their own types are also recommended to change to Flink's JavaSerializer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to