Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3467#discussion_r105143643
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
@@ -265,11 +281,15 @@ public String toString() {
//
------------------------------------------------------------------------
private void returnMemorySegment(MemorySegment segment) {
+ assert Thread.holdsLock(availableMemorySegments);
--- End diff --
Using synchronized again would impact performance, while assertions only do
when they are enabled which is the case in our unit tests (see
https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#enableAssertions).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
