Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104895136
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -333,32 +356,41 @@ public void addEdge(Integer upStreamVertexID, Integer
downStreamVertexID, int ty
downStreamVertexID,
typeNumber,
null,
- new ArrayList<String>());
+ new ArrayList<String>(), null);
}
private void addEdgeInternal(Integer upStreamVertexID,
Integer downStreamVertexID,
int typeNumber,
StreamPartitioner<?> partitioner,
- List<String> outputNames) {
-
+ List<String> outputNames,
+ OutputTag outputTag) {
- if (virtualSelectNodes.containsKey(upStreamVertexID)) {
+ if (virtualOutputNodes.containsKey(upStreamVertexID)) {
+ int virtualId = upStreamVertexID;
+ upStreamVertexID = virtualOutputNodes.get(virtualId).f0;
+ if (outputTag == null) {
+ // selections that happen downstream override
earlier selections
--- End diff --
I think the comment is a leftover from copying this code from split/select.
For side outputs it can't happen that you have multiple "selects" after one
another. Will remove the comment. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
