GitHub user liuyuzhong7 opened a pull request:

    https://github.com/apache/flink/pull/3482

    Flink-5976

    There are some duplicate code like this in flink-test, I think refactor 
this will be better. 
    
    ```
    public final class Tokenizer implements FlatMapFunction<String, 
Tuple2<String, Integer>> {
    
        @Override
        public void flatMap(String value, Collector<Tuple2<String, Integer>> 
out) {
                // normalize and split the line
                String[] tokens = value.toLowerCase().split("\\W+");
    
                // emit the pairs
                for (String token : tokens) {
                        if (token.length() > 0) {
                                out.collect(new Tuple2<String, Integer>(token, 
1));
                        }
                }
        }
    }
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liuyuzhong7/flink FLINK-5976

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3482
    
----
commit 02596f71f8c1ac77b0ade49113a80b07f15cd337
Author: yuzhongliu <yuzhong...@tencent.com>
Date:   2016-12-22T03:36:37Z

    #FLINK-4450 update storm version to 1.0

commit 1dfb469bd6e8d16b18c554c52486477c48dcd3c8
Author: yuzhongliu <yuzhong...@tencent.com>
Date:   2017-01-17T02:41:59Z

    # fix confilct

commit 173913f669c1776572c97384fd4a44409bbecc33
Author: yuzhongliu <yuzhong...@tencent.com>
Date:   2017-01-17T08:37:04Z

    #4450 keep same code with apache/flink

commit 9925bf6f7301b50878e1a0a660ec9e41a7a294ce
Author: liuyuzhong7 <liuyuzho...@gmail.com>
Date:   2017-01-17T08:40:25Z

    Merge pull request #1 from liuyuzhong7/4450-1
    
    #4450 keep same code with apache/flink

commit e51c705290e4394c957480914d9420bcb8cb7657
Author: liuyuzhong7 <liuyuzho...@gmail.com>
Date:   2017-01-17T11:10:25Z

    Merge remote-tracking branch 'upstream/master'

commit 3fa4a7e313b31fc02c9efcb3856b12c5dcd888cb
Author: liuyuzhong7 <liuyuzho...@gmail.com>
Date:   2017-02-07T02:56:27Z

    Merge remote-tracking branch 'upstream/master'

commit 048e69e35bd907fb557582955aaa95b631608c8e
Author: liuyuzhong7 <liuyuzho...@gmail.com>
Date:   2017-02-20T02:37:04Z

    Merge remote-tracking branch 'upstream/master'

commit 4528685f3e6c9d5cee770c0953f6bb11ef5934fb
Author: liuyuzhong7 <liuyuzho...@gmail.com>
Date:   2017-03-07T06:20:05Z

    Merge remote-tracking branch 'upstream/master'

commit 08e9ac564796ad3c3e62e358b5f0174cea451cd0
Author: liuyuzhong7 <liuyuzho...@gmail.com>
Date:   2017-03-07T07:29:47Z

    #FLINK-5967 Refactoring duplicate code in flink-test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to