[
https://issues.apache.org/jira/browse/FLINK-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894286#comment-15894286
]
ASF GitHub Bot commented on FLINK-5861:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3395#discussion_r104132061
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/JobManagerConnectionTest.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.taskexecutor;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.runtime.execution.librarycache.LibraryCacheManager;
+import
org.apache.flink.runtime.io.network.netty.PartitionProducerStateChecker;
+import
org.apache.flink.runtime.io.network.partition.ResultPartitionConsumableNotifier;
+import org.apache.flink.runtime.jobmaster.JobMasterGateway;
+import org.apache.flink.runtime.taskmanager.CheckpointResponder;
+import org.apache.flink.runtime.taskmanager.TaskManagerActions;
+import org.junit.Test;
+
+import java.util.UUID;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static org.junit.Assert.*;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+public class JobManagerConnectionTest {
+
+ @Test
+ public void testJobManagerUpdateListener() {
--- End diff --
It's always good to add a short comment what you're trying to test here.
> TaskManager's components support updating JobManagerConnection
> --------------------------------------------------------------
>
> Key: FLINK-5861
> URL: https://issues.apache.org/jira/browse/FLINK-5861
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, JobManager
> Reporter: Biao Liu
> Assignee: Biao Liu
> Fix For: 1.3.0
>
>
> Some components in TaskManager, such as TaskManagerActions,
> CheckpointResponder, ResultPartitionConsumableNotifier,
> PartitionProducerStateChecker, need to support updating JobManagerConnection.
> So when JobManager fails and recovers, the tasks who keep old
> JobManagerConnection can be notified to update JobManagerConnection. The
> tasks can continue doing their jobs without failure.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
