Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3397#discussion_r102985650
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
 ---
    @@ -171,4 +183,79 @@ class SqlITCase extends 
StreamingMultipleProgramsTestBase {
         val expected = mutable.MutableList("Hello", "Hello world")
         assertEquals(expected.sorted, StreamITCase.testResults.sorted)
       }
    +
    +  @Test
    +  def testUnboundPartitionedProcessingWindowWithRange(): Unit = {
    +    val env = StreamExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env)
    +    StreamITCase.testResults = mutable.MutableList()
    +
    +    val t1 = env.fromCollection(data).toTable(tEnv).as('a, 'b, 'c)
    +
    +    tEnv.registerTable("T1", t1)
    +
    +    //TODO ORDER BY will be fixed, once FLINK-5710 is solved
    +    tEnv.registerFunction("ProcTime", ProcTime)
    +    val sqlQuery = "SELECT c, count(a) OVER (PARTITION BY c ORDER BY 
ProcTime() RANGE " +
    --- End diff --
    
    Since it is a valid SQL query it is accepted. We should make sure though 
that only `ORDER BY proctime()` is allowed. However, that's a bit difficult 
right now, because the information is split across Calc and Window. With a 
ProcTimeType we can check the field type of the input of Window.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to