[ 
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882738#comment-15882738
 ] 

ASF GitHub Bot commented on FLINK-4364:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r102945035
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
 ---
    @@ -105,6 +110,105 @@
        @Rule
        public TestName name = new TestName();
     
    +   @Test
    +   public void testHeartbeatTimeoutWithJobManager() throws Exception {
    +           final JobID jobId = new JobID();
    +           final Configuration configuration = new Configuration();
    +           final TaskManagerConfiguration tmConfig = 
TaskManagerConfiguration.fromConfiguration(configuration);
    +           final ResourceID tmResourceId = new ResourceID("tm");
    +           final TaskManagerLocation taskManagerLocation = new 
TaskManagerLocation(tmResourceId, InetAddress.getLoopbackAddress(), 1234);
    +           final TaskSlotTable taskSlotTable = new 
TaskSlotTable(Arrays.asList(mock(ResourceProfile.class)), 
mock(TimerService.class));
    +
    +           final TestingSerialRpcService rpc = new 
TestingSerialRpcService();
    +           final JobLeaderService jobLeaderService = new 
JobLeaderService(taskManagerLocation);
    +           final TestingHighAvailabilityServices haServices = new 
TestingHighAvailabilityServices();
    +           final TestingLeaderRetrievalService rmLeaderRetrievalService = 
new TestingLeaderRetrievalService();
    +           final TestingLeaderRetrievalService jmLeaderRetrievalService = 
new TestingLeaderRetrievalService();
    +           haServices.setJobMasterLeaderRetriever(jobId, 
jmLeaderRetrievalService);
    +           
haServices.setResourceManagerLeaderRetriever(rmLeaderRetrievalService);
    +
    +           final TestingFatalErrorHandler testingFatalErrorHandler = new 
TestingFatalErrorHandler();
    +
    +           final long heartbeatTimeout = 1000L;
    --- End diff --
    
    I think we should lower the timeout for the test.


> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
>                 Key: FLINK-4364
>                 URL: https://issues.apache.org/jira/browse/FLINK-4364
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: zhijiang
>            Assignee: zhijiang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and 
> the {{TaskManager}} will report metrics info for each heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to