[ 
https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879786#comment-15879786
 ] 

ASF GitHub Bot commented on FLINK-5881:
---------------------------------------

Github user clarkyzl commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3389#discussion_r102632219
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala
 ---
    @@ -48,10 +48,16 @@ class ScalarFunctionCallGen(
           .getOrElse(throw new CodeGenException("No matching signature 
found."))
         val resultClass = getResultTypeClass(scalarFunction, matchingSignature)
     
    +    // zip for variable signatures
    +    var paramToOperands = matchingSignature.zip(operands)
    +    var i = paramToOperands.length
    +    while (i < operands.length) {
    +      paramToOperands = paramToOperands :+ (matchingSignature.head, 
operands(i))
    --- End diff --
    
    I will try to use `getComponentType()`


> ScalarFunction(UDF) should support variable types and variable arguments      
> -------------------------------------------------------------------------
>
>                 Key: FLINK-5881
>                 URL: https://issues.apache.org/jira/browse/FLINK-5881
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Zhuoluo Yang
>            Assignee: Zhuoluo Yang
>
> As a sub-task of FLINK-5826. We would like to support the ScalarFunction 
> first and make the review a little bit easier.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to