[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875649#comment-15875649 ]
Dawid Wysakowicz commented on FLINK-5824: ----------------------------------------- Just two more questions. First I tried to investigate the possibilities to add such a check to checkstyle, but I didn't find a good way to that. Checkstyle does not come with it and a regex check is not enough in that case. It would be possible with FindBugs but don't know if we want to add it right know. Some ideas? Do we want to change also writing to files like e.g: GlobalConfiguration::loadYAMLResource:144 OptimizerPlanEnvironment::getOptimizedPlan:74/76 > Fix String/byte conversions without explicit encoding > ----------------------------------------------------- > > Key: FLINK-5824 > URL: https://issues.apache.org/jira/browse/FLINK-5824 > Project: Flink > Issue Type: Bug > Components: Python API, Queryable State, State Backends, > Checkpointing, Webfrontend > Reporter: Ufuk Celebi > Assignee: Dawid Wysakowicz > Priority: Blocker > > In a couple of places we convert Strings to bytes and bytes back to Strings > without explicitly specifying an encoding. This can lead to problems when > client and server default encodings differ. > The task of this JIRA is to go over the whole project and look for > conversions where we don't specify an encoding and fix it to specify UTF-8 > explicitly. > For starters, we can {{grep -R 'getBytes()' .}}, which already reveals many > problematic places. -- This message was sent by Atlassian JIRA (v6.3.15#6346)