Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3338#discussion_r102040448
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
 ---
    @@ -155,15 +155,15 @@ class ExpressionReductionTest extends TableTestBase {
           "DataSetCalc",
           batchTableNode(0),
           term("select",
    -        "13 AS _c0",
    +        "CAST(13) AS _c0",
    --- End diff --
    
    Yes, because I changed the default nullable to `true`, but the reduced 
constant is `NOT NULL`, so a `CAST` is here. Do you have any ideas to fix this? 
    
    The default nullable changed to `true` is because 
`UserDefinedScalarFunctionTest.testResults` and 
`ArrayTypeTest.testArrayLiterals` fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to