Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3330#discussion_r102035404
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ScalarFunction.scala
 ---
    @@ -58,6 +60,11 @@ abstract class ScalarFunction extends 
UserDefinedFunction {
     
       override def toString: String = getClass.getCanonicalName
     
    +  final def functionIdentifier: String = {
    --- End diff --
    
    In order to keep JAVA's interface and SCALAR's trait consistent, I prefer 
not to do any implementation in UserDefinedFunction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to