Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101942319
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator(
*/
def addReusableFunction(function: UserDefinedFunction): String = {
val classQualifier = function.getClass.getCanonicalName
- val fieldTerm = s"function_${classQualifier.replace('.', '$')}"
+ val functionSerializedData = serialize(function)
+ val fieldTerm =
+ s"""
+ |function_${classQualifier.replace('.',
'$')}_${DigestUtils.md5Hex(functionSerializedData)}
--- End diff --
Hi @wuchong
No, scalar UDF in Scala Table API not works well.
The reason is that when we create `ScalarSqlFunction`, we apply`
scalarFunction.getClass.getCanonicalName` as sql identifier, which produces the
wrong result.
Hi, @fhueske
So far, we have discussed a lot of UDF implementations in this PR, so I
agree with merge FLINK-5794 into this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
