[ 
https://issues.apache.org/jira/browse/FLINK-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869227#comment-15869227
 ] 

ASF GitHub Bot commented on FLINK-5795:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3330#discussion_r101447054
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
 ---
    @@ -324,4 +325,19 @@ object UserDefinedFunctionUtils {
         candidate == classOf[Time] && (expected == classOf[Int] || expected == 
classOf[JInt]) ||
         candidate == classOf[Timestamp] && (expected == classOf[Long] || 
expected == classOf[JLong])
     
    +  @throws[Exception]
    +  def serialize(function: UserDefinedFunction): String = {
    +    val byteArrayOutPut = new ByteArrayOutputStream
    +    val objectOutPut = new ObjectOutputStream(byteArrayOutPut)
    +    objectOutPut.writeObject(function)
    +    objectOutPut.close()
    +    Base64.encodeBase64URLSafeString(byteArrayOutPut.toByteArray)
    --- End diff --
    
    No. we can not use that method. because:
    encodeBase64String  will `Encodes binary data using the base64 algorithm 
into 76 character blocks separated by CRLF.` So,if the binary data more than 76 
character, we'll got `CRLF` which we do not want.


> Improve “UDTF" to support constructor with parameter.
> -----------------------------------------------------
>
>                 Key: FLINK-5795
>                 URL: https://issues.apache.org/jira/browse/FLINK-5795
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to