Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3166#discussion_r101319389
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/util/RexProgramExpressionExtractor.scala
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.rules.util
+
+import java.util
+
+import org.apache.calcite.rel.core.TableScan
+import org.apache.calcite.rex._
+import org.apache.calcite.sql.{SqlKind, SqlOperator}
+import org.apache.calcite.tools.RelBuilder
+import org.apache.flink.table.api.TableEnvironment
+import org.apache.flink.table.expressions._
+import org.apache.flink.table.sources.TableSource
+
+import scala.collection.JavaConversions._
+import scala.collection.JavaConverters._
+import scala.collection.mutable
+
+object RexProgramExpressionExtractor {
+
+ /**
+ * converts a rexProgram condition into expression
+ *
+ * @param rexProgram The RexProgram to analyze
+ * @return converted expression
+ */
+ def extractExpression(rexProgram: RexProgram): Expression = {
+
+ val refInputToName = getInputsWithNames(rexProgram)
+ val visitor = new ExpressionVisitor(refInputToName)
+
+ val condition = rexProgram.getCondition
+ if (condition == null) {
+ return null
+ }
+
+ rexProgram.expandLocalRef(condition).accept(visitor)
--- End diff --
The condition should be converted into conjunctive normal form (CNF) before
translating it. Calcite provides `RexUtil.toCnf()` to do that.
The reason for CNF is that it makes the handling in `FilterableTableSource`
much easier. We could also think about passing the conjunctive terms as a list
to the `FilterableTableSource` and receiving a list of unsupported conjunctive
terms. The list might be shorter but the elements may not change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
