Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101015171
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateProcessor.scala
---
@@ -59,7 +61,9 @@ class DataSetSessionWindowAggregateReduceGroupFunction(
finalRowWindowEndPos: Option[Int],
gap:Long,
isInputCombined: Boolean)
- extends RichGroupReduceFunction[Row, Row] {
+ extends AbstractRichFunction
+ with MapPartitionFunction[Row, Row]
--- End diff --
I like the idea of implementing a joint `MapPartition` and `GroupReduce`
function. However, I think it is not necessary for the final aggregation. We
can also call `DataSet.reduceGroup()` which will do the same as
`DataSet.mapPartition().parallelism(1)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
