Github user shixiaogang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3305#discussion_r100967108
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/migration/util/MigrationInstantiationUtil.java
 ---
    @@ -47,9 +47,16 @@ public ClassLoaderObjectInputStream(InputStream in, 
ClassLoader classLoader) thr
     
                        // the flink package may be at position 0 (regular 
class) or position 2 (array)
                        final int flinkPackagePos;
    -                   if ((flinkPackagePos = 
className.indexOf(FLINK_BASE_PACKAGE)) == 0 ||
    -                                   (flinkPackagePos == 2 && 
className.startsWith(ARRAY_PREFIX)))
    -                   {
    +                   if 
(className.contains("org.apache.flink.runtime.state.ArrayListSerializer")) {
    --- End diff --
    
    The code here is a little tricky. I think we should use a Map to record all 
modified classes and their corresponding backups.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to