joeyutong commented on PR #1175: URL: https://github.com/apache/flink-agents/pull/1175#issuecomment-6210433801
Looks good to me overall. cc @beryllw for awareness: exposing the bucket and an append offset (even the batch base offset) through Fluss `AppendResult` could potentially let this backend use a Kafka-style recovery marker and avoid the extra state refresh writes at checkpoint time. The log-produce response already carries [`base_offset`](https://github.com/apache/fluss/blob/v0.9.0-incubating/fluss-rpc/src/main/proto/FlussApi.proto#L793-L799), but it isn't exposed through `AppendResult` today. Just a possible future enhancement; the current approach looks reasonable for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
