sangkyoonnam commented on PR #1224: URL: https://github.com/apache/flink-agents/pull/1224#issuecomment-6129038653
One more restore interaction, related to #1238. In the restore path, `restoreActionTask` identifies run ids before `restoreActiveInputRuns` sets the anonymous restored-key count, and the fix proposed in #1238 subtracts the already identified runs from that count. At 1da2fa63 the new noop `continue` also skips identifying the input run. For a restore with one processing key, no pending inputs and one retained noop task with a non-null run id, `numOfActiveInputRuns` reads 1 after restore and stays 1 after completion, because `finish(...)` only consumes an anonymous slot for a null id. On main at 9af407ed the same case reads 2 then 1 because of the double count in #1238. With the proposed #1238 fix, main would read 1 then 0, while this PR would still read 1 then 1. Could the noop path still identify the run and only skip the action-level metrics, for example through a run-only method on `BuiltInMetrics`? I haven't run this restore case; the values follow from the code at 1da2fa63 and 9af407ed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
