Martijn Visser created FLINK-40977:
--------------------------------------

             Summary: ForSt JUnit 5 migration is incomplete
                 Key: FLINK-40977
                 URL: https://issues.apache.org/jira/browse/FLINK-40977
             Project: Flink
          Issue Type: Technical Debt
          Components: Tests
            Reporter: Martijn Visser


A few JUnit 4 leftovers are still in {{flink-statebackend-forst}} on master: 
{{ForStExtension}} uses {{org.junit.rules.TemporaryFolder}}, and 
{{ForStStateMigrationTest}} and {{ForStStateDataTransferTest}} still use 
{{org.junit.Assert}} ({{ForStStateDataTransferTest}} also extends 
{{TestLogger}}). The RocksDB migration in FLINK-29775 replaces the same 
{{TemporaryFolder}} in {{RocksDBExtension}} with a plain temp directory, that 
works here too. Also, the {{@Timeout(value = 60)}} on 
{{ForStStateBackendConfigTest#testCleanRelocatedDbLogs}} only became active 
with this migration, since vintage ignored it. We avoid local timeouts in 
tests, so it can go.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to