[ 
https://issues.apache.org/jira/browse/FLINK-40971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126330#comment-18126330
 ] 

Purushottam Sinha commented on FLINK-40971:
-------------------------------------------

Do we need to track 1.18.1?

> ParquetTimestampITCase never runs its parameterized cases
> ---------------------------------------------------------
>
>                 Key: FLINK-40971
>                 URL: https://issues.apache.org/jira/browse/FLINK-40971
>             Project: Flink
>          Issue Type: Bug
>          Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile), Tests
>    Affects Versions: 1.18.1, 2.2.1, 1.20.5, 2.3.1, 2.4.0
>            Reporter: Martijn Visser
>            Assignee: Martijn Visser
>            Priority: Major
>
> {{ParquetTimestampITCase}} (FLINK-25565) is meant to cover writing Parquet 
> INT64 timestamps, but its parameters are never applied. The tests are plain 
> {{@Test}} methods inherited from {{FsStreamingSinkITCaseBase}}, so 
> {{ParameterizedTestExtension}} does not apply, and all three {{@Parameter}} 
> fields use index 0. Each test runs once with the field defaults (useInt64 
> false, timeunit null). CI reports {{Tests run: 4}} instead of 28, so the 
> INT64 path is not covered.
> We should run the inherited tests as {{@TestTemplate}} in this class, for 
> example by overriding them, and give the parameter fields indices 0, 1 and 2.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to