MartijnVisser commented on code in PR #28382:
URL: https://github.com/apache/flink/pull/28382#discussion_r4245866613
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ChangelogNormalizeTestPrograms.java:
##########
@@ -54,6 +54,7 @@ public class ChangelogNormalizeTestPrograms {
Row.ofKind(RowKind.UPDATE_BEFORE, "four", 4, "d"),
Row.ofKind(RowKind.UPDATE_AFTER, "four", 4, "dd"),
Row.ofKind(RowKind.INSERT, "six", 6, "f"),
+ Row.ofKind(RowKind.DELETE, "seven", 7, "g"),
Review Comment:
This delete is for a key that was never inserted, so it only passes because
ChangelogNormalize drops it. Could you move `+I six` after `+I five` instead,
with a comment on the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
