joeyutong commented on PR #1160: URL: https://github.com/apache/flink-agents/pull/1160#issuecomment-6118942581
Sorry for the delayed review, and for not flagging the overlap earlier. I’ve been working on unifying Event Log into Trace Log, described in [Discussion #1146](https://github.com/apache/flink-agents/discussions/1146) and implemented in [PR #1219](https://github.com/apache/flink-agents/pull/1219). I went through this PR and compared it with the new Trace Log model. The execution identities, hierarchy, and lifecycle semantics that this exporter relies on remain consistent, so I think the overall design and most of the implementation are still applicable. The main adaptation would be to consume the unified `TraceRecord` model and update lifecycle recognition; the span mapping and OTLP export approach can largely be retained. For sequencing, I suggest landing #1219 first, then rebasing and adapting this PR to the new recording contract. We can continue reviewing the span reconstruction and export logic in the meantime, and I’d be happy to help with the adaptation. Would that work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
