sarkaramrit1993 opened a new pull request, #29451:
URL: https://github.com/apache/flink/pull/29451
## What is the purpose of the change
The Scale column in the job overview only checks the cluster-level
`web-rescale` flag. On a cluster with the adaptive scheduler, batch jobs are
switched to the `AdaptiveBatchScheduler`, which doesn't support resource
requirement updates. The column still shows up for them, and clicking the
buttons ends in a 500 ("Internal server error.") from `GET
/jobs/:jobid/resource-requirements`.
## Brief change log
- `JobOverviewComponent` works out whether the job can be rescaled with the
same check the Rescales tab already uses: a streaming plan on the `Adaptive`
scheduler.
- `JobOverviewListComponent` takes that as an input and only shows the Scale
column when both the cluster flag and the job allow it.
## Verifying this change
This change added tests and can be verified as follows:
- New `job-overview-list.component.spec.ts`: the Scale column shows when the
flag is on and the job supports rescaling, and is hidden when the job doesn't
or the flag is off.
- `job-overview.component.spec.ts`: a streaming job on the adaptive
scheduler is rescalable, a batch job and a job with an unknown scheduler are
not.
- `npx ng test --watch=false`: 67 spec files / 284 tests pass. `eslint` and
`prettier --check` are clean.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
