eskabetxe commented on code in PR #29422:
URL: https://github.com/apache/flink/pull/29422#discussion_r4230303382
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableSerializer.java:
##########
@@ -41,6 +41,10 @@ final class S3RecoverableSerializer implements
SimpleVersionedSerializer<S3Recov
private static final int MAGIC_NUMBER = 0x98761432;
+ // The wire format below is frozen: flink-s3-fs-native
(NativeS3RecoverableSerializer)
+ // duplicates this decoder to restore state after switching to that plugin
(FLINK-40943).
+ // Do not change the format without keeping that decoder in sync.
Review Comment:
Could be one time step, if the old serializer ever changed, we would have to
copy the new format again.
I dont know the roadmap, but if we are left behind the old formats, they
should not receive more changes, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
