snuyanzin commented on code in PR #29438:
URL: https://github.com/apache/flink/pull/29438#discussion_r4228836413
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala:
##########
@@ -565,10 +565,13 @@ class ExprCodeGenerator(
* - `CASE(when_1, then_1, when_2, then_2, ..., else)`: only `when_1` is
unconditional.
* - `AND(a_0, a_1, ..., a_n)` / `OR(...)`: only `a_0` is unconditional;
subsequent operands are
* short-circuited by the operator semantics and the codegen.
+ * - `IF(cond, then, else)`: only `cond` is unconditional; `IfCallGen`
guards `then`/`else`.
*/
private def conditionalOperandIndices(call: RexCall): Set[Int] =
call.getKind match {
case SqlKind.CASE | SqlKind.AND | SqlKind.OR | SqlKind.COALESCE =>
Review Comment:
thanks for flagging
since it might require restore tests i would do it separately (first try to
repro it locally)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
