raminqaf commented on PR #29411: URL: https://github.com/apache/flink/pull/29411#issuecomment-6038895124
> can we have a query similar to [#29285 (comment)](https://github.com/apache/flink/pull/29285#issuecomment-5939145317) (with variants) and see that it fails if we turnoff all kind of joins except SortMergeJoin? > > for instance in this test SortMergeJoinTest Thanks, good check. I ran a `VARIANT` version of your probe in batch with t`able.exec.disabled-operators = 'HashJoin, NestedLoopJoin'`, as in `SortMergeJoinTest`, and also with 'ShuffleHashJoin, BroadcastHashJoin'. Both `SELECT a, d FROM Tiny, Huge WHERE m = n and ... ON m['id'] = n['id']` now fail with `An expression of type VARIANT cannot be used in a comparison with '=', because the type has no equality`. Without this PR they plan a `SortMergeJoin` on the `VARIANT` key. The check runs before the optimizer picks a join strategy, so the disabled operators make no difference. The `CAST` workaround still plans a `SortMergeJoin`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
