MartijnVisser commented on code in PR #29352:
URL: https://github.com/apache/flink/pull/29352#discussion_r4197280550
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ProcessTableFunctionTestPrograms.java:
##########
@@ -1678,19 +1678,30 @@ public class ProcessTableFunctionTestPrograms {
"process-stateful-multi-input-with-timeout",
"joins two tables and emits the left side after a
timeout if there is no right side")
.setupTemporarySystemFunction("f", TimedJoinFunction.class)
- .setupTableSource(TIMED_SOURCE)
+ // The two inputs may reach eval() in any interleaving. To
keep the output
+ // independent of it, a key with a city has a single score
with the same
+ // timestamp as its city. Keys without a city may have
multiple scores.
Review Comment:
With this data, no key gets an event after its join, so nothing checks
anymore that `ctx.clearAllTimers()` keeps the state. Could you add a small
single-input program for that?
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ProcessTableFunctionTestUtils.java:
##########
@@ -105,7 +105,11 @@ public class ProcessTableFunctionTestUtils {
"city STRING",
"ts TIMESTAMP_LTZ(3)",
"WATERMARK FOR ts AS ts - INTERVAL '0.001' SECOND")
- .producedValues(Row.of("Bob", "London",
Instant.ofEpochMilli(0)))
+ .producedValues(
Review Comment:
Nit: this is now only used by that one program and has to match its scores,
so I would inline it there next to the score source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
