Zakelly opened a new pull request, #29392:
URL: https://github.com/apache/flink/pull/29392

   ## What is the purpose of the change
   
   Fix the wierd implementation of `StreamOperatorStateHandler::dispose`, which 
register the `close` then `dispose` of each state backend but the actually the 
Guava's closer close things in a reverse order. It seems we should do `close` 
before `dispose`.
   
   ## Brief change log
   
   - Register cleanup actions so Guava `Closer` invokes `close()` before 
`dispose()`.
   - Close backends before disposal in `StateBackendTestBase` and remove 
redundant disposal.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`StreamOperatorStateHandlerTest` and `StateBackendTestBase` subclasses, 
including RocksDB and Changelog backend tests.
   
   These commits have not been retested.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes — state backend 
cleanup
   - The S3 file system connector: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to