skywalker0618 opened a new pull request, #29391:
URL: https://github.com/apache/flink/pull/29391
## What is the purpose of the change
When the TCP connection between two task managers is closed or reset, the
`RemoteTransportException` raised on the consumer side only names the remote
(destination) task manager. When debugging network failures it is often
necessary to know which host/port on the local side the broken connection
belonged to, so this PR adds the local channel address to those messages.
Example:
```
Connection unexpectedly closed by remote task manager '/10.0.0.2:41234 [
tm-2 ] ' (local address: '/10.0.0.1:50312'). This might indicate that the
remote task manager was lost.
```
## Brief change log
- `CreditBasedPartitionRequestClientHandler#channelInactive` includes the
local address in the "Connection unexpectedly closed by remote task manager"
error.
- `CreditBasedPartitionRequestClientHandler#exceptionCaught` includes the
local address in the "Lost connection to task manager" error (connection reset
by peer).
- Existing message prefixes are unchanged so that log searches/alerts on
them keep working.
## Verifying this change
This change added tests and can be verified as follows:
- Added
`CreditBasedPartitionRequestClientHandlerTest#testChannelInactiveErrorContainsLocalAndRemoteAddress`
and `#testConnectionResetErrorContainsLocalAndRemoteAddress`, which use an
`EmbeddedChannel` with distinct local/remote addresses and assert both appear
in the error message. Both tests fail without the change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Cursor (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
