gustavodemorais commented on code in PR #29380:
URL: https://github.com/apache/flink/pull/29380#discussion_r4183708391
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/StreamNonDeterministicUpdatePlanVisitor.java:
##########
@@ -630,6 +631,10 @@ private StreamPhysicalRel visitJoin(
throwNonDeterministicConditionError(
Review Comment:
nit: LSJ still goes through the generic non-deterministic condition check.
That rejects a non-deterministic join condition whenever the build side updates
or the join is a LEFT join, even with insert-only inputs. For LSJ that's
stricter than needed: the output is append-only and the condition is only
evaluated when a probe row arrives, never when build rows are retracted. Up to
you if we want to change this in this ticket or follow up ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
